Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dri3.patch needs an update. #5

Open
roninspin opened this issue Sep 19, 2024 · 15 comments
Open

dri3.patch needs an update. #5

roninspin opened this issue Sep 19, 2024 · 15 comments

Comments

@roninspin
Copy link

roninspin commented Sep 19, 2024

Please, update dri3.patch (file src/vulkan/wsi/wsi_common_x11.c).
Something like this should do:
dri3.patch

@nydal91
Copy link

nydal91 commented Sep 28, 2024

Bump

@MastaG
Copy link
Owner

MastaG commented Sep 28, 2024

Sorry I'm currently away on vacation.
I was getting the failed build CI messages for a while now.
Feel free to rebase the patch and open a PR.
Otherwise I'll do it in a couple of weeks.

@peraltaklark
Copy link

Please, update dri3.patch (file src/vulkan/wsi/wsi_common_x11.c). Something like this should do: dri3.patch

error: corrupt patch at line 334

@Jacobw1oo
Copy link

Jacobw1oo commented Oct 1, 2024

Attempted to patch, fixed 13 mismatch issues, there are 2 i tried to fix but not confident there fully correct (notes in request). It is awaiting your checking and approval to be merged.

Edit: After testing i am now confident, patch apples with no errors.

It is awaiting your checking and approval to be merged.

@nydal91
Copy link

nydal91 commented Oct 3, 2024

Ca

Attempted to patch, fixed 13 mismatch issues, there are 2 i tried to fix but not confident there fully correct (notes in request). It is awaiting your checking and approval to be merged.

Edit: After testing i am now confident, patch apples with no errors.

It is awaiting your checking and approval to be merged.

Can you upload the dri patch here?

@Jacobw1oo
Copy link

Sure here, i just built it and tested it against newest Mesa yesterday.
dri3.patch.txt

@peraltaklark
Copy link

Sure here, i just built it and tested it against newest Mesa yesterday. dri3.patch.txt

bro try it with latest dxvk 2.4.1 it doesnt work getting error

@nydal91
Copy link

nydal91 commented Oct 3, 2024

Test it now, have zero problem with dxvk so far

@Jacobw1oo
Copy link

Jacobw1oo commented Oct 3, 2024

Sure here, i just built it and tested it against newest Mesa yesterday. dri3.patch.txt

bro try it with latest dxvk 2.4.1 it doesnt work getting error

I understand, try to find very small program that uses dxvk and run it with the Linux command: gdb % rest of command %
This will isolate the first package that causes breaks. A mouth ago for me it was ibglx-mesa0_24.3~git2409030600.

Edit: Reason for very small program is that gdb is very slow. walking though a program running block by block.

@peraltaklark
Copy link

Test it now, have zero problem with dxvk so far

use dxvk2.4.1. previous version works but latest dxvk wont work. it works on Winlator and other drivers I've tried.

@Jacobw1oo
Copy link

I check my newest version is 2.3, if the drive works for other version. I don't know to to test or check why 2.4 is struggling.

@peraltaklark
Copy link

check dxvk github. get the dxvk 2.4.1 and put it beside the .exe and run the game it will run then graphics will freeze at some part of game

@MastaG
Copy link
Owner

MastaG commented Oct 7, 2024

I just rebased the dri3 patch and launchpad built new packages for both 24.04 and 24.10.
Try doing apt update + upgrade.

@blazingcody0707
Copy link

Your dri3 patch also works with mobox

@MastaG
Copy link
Owner

MastaG commented Oct 12, 2024

Thats nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants