Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Songwriter/Web tags in M4A #119

Open
hsn10 opened this issue Oct 16, 2024 · 12 comments
Open

Add support for Songwriter/Web tags in M4A #119

hsn10 opened this issue Oct 16, 2024 · 12 comments

Comments

@hsn10
Copy link

hsn10 commented Oct 16, 2024

I would like to use tageditor as replacement for Studio One 5 which I use for editing ALAC M4A files.

Following fields are not implemented:

  1. Web site
  2. Songwriter

studio-one-5

@Martchus
Copy link
Owner

Can you specify what field IDs are used for these fields or point me to a documentation/Wiki page? Maybe the output of tageditor get --show-unsupported -f /path/to/your/file.m4a is also sufficient. Otherwise you could also upload a sample file with those fields.

With this information this is probably implemented in 5 minutes :-)

@hsn10
Copy link
Author

hsn10 commented Oct 16, 2024

what all file formats you need it. looks like songwriter is written only to mp3, not m4a.

@Martchus
Copy link
Owner

Well, if you don't have or can't produce a sample M4A file or can otherwise point out the field IDs you want to have support for I cannot help. Of course I could make something up but it wouldn't be useful because probably no other applications would understand it.

I can also add support for more fields in MP3 files (or rather ID3v2 tags) but I would also need to know what field IDs you mean exactly.

Note that this tag editor supports the field "Written by" and many more. Checkout the settings dialog for all supported fields. Not all are supported by all formats, though.

@hsn10
Copy link
Author

hsn10 commented Oct 16, 2024

@Martchus
Copy link
Owner

Good, I'll look into these in the next days.

@hsn10
Copy link
Author

hsn10 commented Oct 16, 2024

Its free hosting service, it will have unlikely stored files for long.

@Martchus
Copy link
Owner

Yes, I've already downloaded them.

@Martchus
Copy link
Owner

It looks like the only file that has a field with the value "Wrote by ARP (songwriter)" present is the MP3 file. So I assume support for the "songwriter" field is only relevant for MP3 files (or rather ID3v2 tags) for you after all (despite the issue title stating M4A). The good news is that this field is already supported by Tag Editor in basically all formats it generally supports. It is called "Lyricist" in Tag Editor but maps to the same underlying field as in your MP3 example file. That means you could use Tag Editor to add this field also to your M4A, FLAC, Opus and Vorbis files as well using "Lyricist". Whether it can then be display by specific other tools such as Studio One I cannot tell.

It looks like your files that use Vorbis Comments (FLAC, Opus, Vorbis) contain the field "ARRANGER" which is not supported by Tag Editor at this point for Vorbis Comments (only for MP4 and Matroska tags). I can add support for that in Vorbis Comments as well.

It looks like your files that use Vorbis Comments (FLAC, Opus, Vorbis) contain the field "WEBSITE" (with the value https://github.com) which is not supported by Tag Editor at this point. I can add support for that in Vorbis Comments.

It looks like your MP3 file contains the field "Official artist/performer webpage" (with the value https%3A%2F%2Fgithub.com) which is not supported by Tag Editor at this point for ID3v2 tags. I can add support for such fields in MP3 tags.

You also uploaded AIFF and WAV files. These are completely unsupported by Tag Editor so they are out of scope for this ticket. Adding support for those formats would be a valid feature request but I'm not sure whether I'll take the effort of implementing that anytime soon.

@Martchus
Copy link
Owner

The TYER field in your MP3 file contains an invalid value which Tag Editor complains about correctly. See https://github.com/id3/ID3v2.3/blob/69c4641b049de54c97c9eb0c57b13508008a1124/id3v2.3.0.txt#L854 for allowed values of that field. I suppose it wouldn't hurt if Tag Editor would nevertheless get at least the first valid part of the value.

@hsn10
Copy link
Author

hsn10 commented Oct 27, 2024

AIFF is second most popular DJ format because software reads these tags perfectly. Common DJ software won't read tags from OGG or WAV.

@Martchus
Copy link
Owner

But for me this format has zero relevance. So don't expect this to be implemented anytime soon. Of course this is an open source project and I'd of course accept contributions in that regard. (The implementation would mainly be in the tagparser library.)

@hsn10
Copy link
Author

hsn10 commented Oct 28, 2024

C/C++ projects are too difficult for contributing.

Setup to get stuff compiled is difficult and language is annoying with all that manual memory management and stuff. In javascript you just npm install stuff and you can go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants