Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Modal is falsely blocked due to possible csrf attack #56

Open
pa7r1ck opened this issue Feb 15, 2016 · 4 comments
Open

Bootstrap Modal is falsely blocked due to possible csrf attack #56

pa7r1ck opened this issue Feb 15, 2016 · 4 comments
Labels

Comments

@pa7r1ck
Copy link

pa7r1ck commented Feb 15, 2016

Hey Marc,
i checked out your project yesterday an it works great so far.
I encountered a problem recently with the 'Wicket Bootstrap'-Api (https://github.com/l0rdn1kk0n/wicket-bootstrap).

As soon as i open a modal window the application recognizes a possible csrf attack because the origin of the request is empty.

Log says: INFO 869808 --- [nio-8080-exec-7] w.p.h.CsrfPreventionRequestCycleListener : Possible CSRF attack, request URL: http://localhost:8080/, Origin: null, action: allowed

Regards, pa7r1ck

@martin-g
Copy link
Contributor

I am not sure this issue belongs here.
It looks to me like an issue with CsrfPreventionRequestCycleListener, i.e. it should be in Wicket's JIRA.

@MarcGiffing
Copy link
Owner

@MarcGiffing
Copy link
Owner

https://issues.apache.org/jira/browse/WICKET-6101

Martijn Dashorst : As you can see in the log, the request is not blocked. The origin header was not set, and the action is allowed. It is logged to ensure that the developer knows which Origin headers are being sent if at all, to be able to finetune the whitelist. See the documentation of the CsrfPreventionRequestCycleListener for more information on the configuration options.

On every request you get the log information which is a little bit annoying. When does the origin header is set? Only if the origin is different? The whitelist check is not executed cause the origin header is null. One must verify that this behavior is right.

@MarcGiffing
Copy link
Owner

MarcGiffing added a commit that referenced this issue Apr 26, 2019
- revert changes - a conditional csrf listener is needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants