Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @RateLimiting on class level #256

Closed
MarcGiffing opened this issue Mar 12, 2024 · 0 comments · Fixed by #257
Closed

Support @RateLimiting on class level #256

MarcGiffing opened this issue Mar 12, 2024 · 0 comments · Fixed by #257
Milestone

Comments

@MarcGiffing
Copy link
Owner

It would be nice if @ratelimiting can be used on class level. It enables the rate limiting on all public methods. Maybe we can also use a @IgnoreRateLimiting to exclude a method. The question is should the method level @ratelimiting annotation overrides the class level annotation completely or should we have two independent configurations.

@RateLimiting
public class MyService {

  public void method1() {
  }

  public void method2() {
  }
  
  @RateLimiting
  public void methodWithExtraAnnotation() {
  }
 
 @IgnoreRateLimiting
 public void methodToIgnore{
 }
 
}
@MarcGiffing MarcGiffing added this to the 0.12.0 milestone Mar 12, 2024
@MarcGiffing MarcGiffing linked a pull request Mar 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant