Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new type of light cone preview #8

Open
HoraceHuang-ui opened this issue Aug 22, 2023 · 5 comments
Open

Adding a new type of light cone preview #8

HoraceHuang-ui opened this issue Aug 22, 2023 · 5 comments

Comments

@HoraceHuang-ui
Copy link

HoraceHuang-ui commented Aug 22, 2023

Is it possible to add a preview image of light cone as on the lower-right corner of Characters UI?
Light cone preview
For this preview varies for each light cone, it's a hard work for us to do this manually.
Or maybe it's okay to return an additional value indicating the y-offset, e.g. for 在蓝天下(as shown above), it's approximately 40%, instead of returning an image like above.

@mobyw
Copy link
Member

mobyw commented Aug 24, 2023

It is displayed according to the config y-axis offset, but I haven’t analyzed the corresponding relationship between the value and the percentage. If you have already done part of it, can you provide some comparisons between the full-picture and these preview pictures?

@HoraceHuang-ui
Copy link
Author

No I haven't started, but if it's ok I can help in the next few days.

If so, how shall I do this? Like take a screenshot of the preview, rename it as the light cone id, and upload to a repo, is that ok?

Also note that I don't have all the light cones:(

@mobyw
Copy link
Member

mobyw commented Aug 24, 2023

No manual operation required, I will analyze the corresponding relationship of the coordinates and add the offset value to light_cones.json

@mobyw
Copy link
Member

mobyw commented Aug 27, 2023

In addition to reference offset, these preview use a different zoom ratio, so it may take some time to create.

@HoraceHuang-ui
Copy link
Author

Thanks for your effort, never thought it'd be that complicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants