Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing is focused when a layer is removed using the layer control #589

Closed
Anshpreet8 opened this issue Nov 22, 2021 · 3 comments · Fixed by #600
Closed

Nothing is focused when a layer is removed using the layer control #589

Anshpreet8 opened this issue Nov 22, 2021 · 3 comments · Fixed by #600
Assignees

Comments

@Anshpreet8
Copy link
Contributor

Tab to the remove layer button on the layer control and press enter.

Expected: the next element should be focused
Actual: Nothing is focused

@Malvoz
Copy link
Member

Malvoz commented Nov 23, 2021

Expected: the next element should be focused

I guess the next element refers to the next layer item?

Another consideration is when all layers have been removed, what should be focused then? The map perhaps?

@Anshpreet8
Copy link
Contributor Author

Another consideration is when all layers have been removed, what should be focused then? The map perhaps?

Yes, the map makes sense. Or potentially the links at the bottom right as the tab order is the layer control then links?

@Malvoz
Copy link
Member

Malvoz commented Nov 24, 2021

I think the attribution links are inherently a bit confusing because there's no context to what they're for:

#247 (comment):

  • The container element for the attribution should provide contextual information, e.g. role="group" aria-label="Map data attribution" (or a control to toggle attribution should be labelled, per Collapse attribution behind a control #216).

But even so, I agree that's the logical thing to do. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants