-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for propshaft (#2) #114
Conversation
CI failed Please fix when you can~ |
There are some files that appear on the linter when running
¿Should I fix them too on this PR ? |
Yes please |
There is a problem here. lib/roadie/rails/mailer.rb:11:9: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
lib/roadie/rails/mailer.rb:13:31: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
lib/roadie/rails/options.rb:109:23: Performance/StringIdentifierArgument: Use `:"#{option}="` instead of `"#{option}="`. Fixing the one in But the anonymous block arguments forwarding is a feature added in ruby 3.1 I don't think that's part of the PR. but I don't know why the linter is now failing. What should we do? |
Coz the lint job is run on ruby 3.2 |
Done @PikachuEXE I added |
- 'lib/roadie/rails/mailer.rb': | ||
- Style/ArgumentsForwarding | ||
- 'lib/roadie/rails/options.rb': | ||
- Performance/StringIdentifierArgument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing new line at the end again :P
I will add https://editorconfig.org and set insert_final_newline
You should setup your editor(s)/IDE(s) to follow https://editorconfig.org config if present (though I have never seen any project allowing missing new line
I will simply merge and fix it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops sorry!
CI failing now due to actual path shorten |
I will check it out. |
@jvillarejo Any progress? Edit 1: rails/propshaft#173 ? |
Sorry @PikachuEXE I been having some rough weeks. I had this on my TODO list. |
Hey @PikachuEXE I made the PR that fixes the tests: #115 Again, sorry for the delay. I had some very busy weeks. |
It's simply test case no urgency at all! :) |
I am migrating my webapp to use propshaft and dartsass and removing sprockets as the asset pipeline.
This PR introduce a new
AssetPropshaftProvider
to resolve the assets instead of theAssetPipelineProvider
.Researching
propshaft
more I ended replicating a similar idea implemented in thePropshaft::Server
class.We need to provide
roadie
with the compiled stylesheet, so it can:url(...)
on the stylesheet.sass
is being used.Now the integration_spec works without requiring the assets to be compiled.
It serves the compiled assets when running in development environment (which the dummy apps run)
I also added expectations for the body ``background-color: green` inlining.
It fixes #112