Skip to content
This repository has been archived by the owner on Nov 12, 2023. It is now read-only.

Redundant typeof BaseEntity typing #29

Open
Defus-E opened this issue Apr 18, 2022 · 1 comment
Open

Redundant typeof BaseEntity typing #29

Defus-E opened this issue Apr 18, 2022 · 1 comment

Comments

@Defus-E
Copy link

Defus-E commented Apr 18, 2022

I noticed that both GraphQLDatabaseLoader and GraphQLQueryBuilder use generic extending typeof BaseEntity which is incorrect in some cases because Entity might not be extended from BaseEntity. It enables some difficulties to implement correct typing in real use. It seems everything works great if entity isn't extended from BaseEntity, so I think it's redundant typing. Please, fix it.
@script-sorcerer
Copy link

script-sorcerer commented Apr 20, 2022 •
edited
Loading

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Defus-E @script-sorcerer