From 84841931513ff55db963df0cb33b378cf5712c7c Mon Sep 17 00:00:00 2001 From: Fabian Dill Date: Mon, 15 Aug 2022 20:16:12 +0200 Subject: [PATCH] Core: crash if non_local pool is too big --- Fill.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Fill.py b/Fill.py index a5cf155ec19f..e44c80e720ee 100644 --- a/Fill.py +++ b/Fill.py @@ -220,8 +220,8 @@ def distribute_items_restrictive(world: MultiWorld) -> None: world.push_item(defaultlocations.pop(i), item_to_place, False) break else: - logging.warning( - f"Could not place non_local_item {item_to_place} among {defaultlocations}, tossing.") + raise Exception(f"Could not place non_local_item {item_to_place} among {defaultlocations}. " + f"Too many non-local items for too few remaining locations.") world.random.shuffle(defaultlocations)