-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Windows related improvements #112
Comments
Thank you for offering to help ❤️ I certainly would love to see more and more readouts get implemented for Windows, as its current state is pretty unfortunate, to say the least... I am very confident though that the Windows implementation will only improve over time, since we've got @FantasyTeddy helping out. I personally can't promise to work on Windows, but I am around (most of the time) to answer any questions, and review any PRs you might send our way. |
I tend to agree with this comment there:
Since libmacchina was originally intended for use with macchina itself (I assume), it'd be good to have everything available as default, with the ability to selectively turn off features if developers require. |
Yeah, that is currently how it works in #111, I'll drop a video of the progress so we can visualize the changes. |
Hi!
I've recently started learning Rust, and I'd like to help out by improving
macchina
on Windows. I have a decent background in fetching system information - I'm a maintainer of winfetch (you might remember me from this thread).This is the current state of
macchina
on Windows:I believe the Packages readout was fixed recently - #105, #107.
But from the remaining 8 warnings, 5 readouts, namely Terminal, Shell, Backlight, Resolution and ProcessorLoad are relevant and possible to implement (and fairly easy too, at least from a CLI perspective, not sure about the Rust implementation since I'm new to it).
I see that the
wmi
dependency was recently added - #97. This is great! WMI contains a goldmine of information and we use it heavily in winfetch1.For both Resolution and Backlight, we can use WMI - see here and here.
I will try to implement the Backlight function first.
Footnotes
10 function calls to
Get-CimInstance
as of now. ↩The text was updated successfully, but these errors were encountered: