-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments icon colored with no new comments #573
Comments
I can reproduce it in development. Starting scenario: Teacher has no unread comments. Student posts new comment for a medium that does not have a comment yet (I could not reproduce it with a medium that had previuos comments). Teacher's new_comment icon in the navbar turns yellow. Teacher replies to the comment. Then Teacher clicks on the yellow new_comments icon and finds that it does not show anything. |
A quick inspection of the code in |
It appears that #515 contains a bug: In production I just posted an answer to a user comment on one of my media, and now I have a yellow comment icon in the navbar indicating that there are new comments, while clicking on the icon shows there are none:
There is no way to decolor the yellow icon (only waiting until someone posts a new commmment somewhere and the clearing all commments). This is actually something we wanted to avoid in #515 but for some reason, it does not work.
The text was updated successfully, but these errors were encountered: