Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible translation fix in FF8-Remastered. #176

Open
RJesusTVD opened this issue Feb 27, 2021 · 1 comment
Open

Possible translation fix in FF8-Remastered. #176

RJesusTVD opened this issue Feb 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@RJesusTVD
Copy link
Contributor

Hello.
First time reporting a issue here. Hope it can help.

This line is causing the selection of german language.

var result = OrderedByName.FirstOrDefault(x => x.Key.IndexOf(localInput, StringComparison.OrdinalIgnoreCase) > -1);

Since its using the first finding, it will always select the "lang-de" and it will not look in any other language folder. Maybe use the language indicator that is defined in Memory class and check against the localInput path.

If it can find the file in the root of the data folder, go on with it. Otherwise it should look for the file in the language related folders.

@Sebanisu
Copy link
Collaborator

I think that's mainly an issue on remaster. The other versions only have one language installed at a time.

@Sebanisu Sebanisu added the bug Something isn't working label Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants