New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insight] Symfony controller action method should not be too long #88

Open

gonzaloalonsod opened this issue Oct 20, 2016 · 0 comments

Contributor

gonzaloalonsod commented Oct 20, 2016

28% of all actions have more than 20 lines. This violation is raised when more than 10% actions are too long.

34 lines for BackendController::ajaxEnabledDisabledAction() in Controller/BackendController.php, line 30
24 lines for DefaultController::updateAction() in Controller/DefaultController.php, line 410
21 lines for DefaultController::createAction() in Controller/DefaultController.php, line 209

Posted from SensioLabsInsight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment