Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are reporting incomplete downloads #22

Closed
d3v-null opened this issue May 22, 2024 · 2 comments
Closed

Users are reporting incomplete downloads #22

d3v-null opened this issue May 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@d3v-null
Copy link
Contributor

This may be a scratch issue, but some users are reporting that giant-squid download will return succesfully, but upon inspecting the output files, some have null access times.

In the design of download jobs, I recommend checking that the contents of the archive are extracted succesfully using sha1sum -c birli_manifest.sha1sum. This will ensure that all file access times are updated, and those files don't get purged.

@d3v-null
Copy link
Contributor Author

it may be extremely over-engineered, but so far this method of downloading observations has survived thousands of observations with no file corruption issues.

https://github.com/MWATelescope/MWAEoR-Pipeline/blob/065c38e10922d2f46ed6ace6cb24f4e8f980c56a/main.nf#L815

@gsleap
Copy link
Member

gsleap commented May 23, 2024

Looks like this is nothing to do with /scratch. mtime AND atime are both 0 even in my local filesystem.

Looks like this issue is why mtime no longer gets propagated from the files within the tar. It looks like this is intended behaviour from the tar crate :-( . Looking to see what can be done....

@gsleap gsleap closed this as completed in 45908e3 May 23, 2024
@gsleap gsleap self-assigned this May 23, 2024
@gsleap gsleap added the bug Something isn't working label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants