Tech - Migre la liste des règlementations du BackOffice vers Typescript #3777

ivangabriele · 2024-10-17T13:25:19Z

Linked issues

Re-activer le test src/features/Reporting/components/ReportingCard/__tests__/ReportingCard.skippedtest.tsx
Il y a un input qui passe de controlled à uncontrolled dans le form d'édition d'une rég
AuthorizationShould redirect to login page if an API request is Unauthorized passe en local (chez moi) mais pas sur la CI
Renommer MainMap en MonitorfishMap + merger features/map/* dedans
Il semble y avoir un lag au moment du chargement de la carte, mais c'est peut-être une hallucination.

Tests E2E (Cypress)

frontend/src/features/AdministrativeZone/components/AdministrativeZones/index.tsx

frontend/src/features/AdministrativeZone/layers/AdministrativeLayers.tsx

louptheron · 2024-11-28T15:22:55Z

frontend/src/features/Vessel/components/VesselList/VesselListFilters.tsx

@@ -196,21 +196,18 @@ function UnmemoizedVesselListFilters({ seeMoreIsOpen, setSeeMoreIsOpen }: Vessel

  // TODO Export to a thunk use-case
  const getZones = useCallback(async () => {
-    const nextZonesPromises = dispatch(getZonesAndSubZonesPromises())
-    const nextZones = await Promise.all(nextZonesPromises)
+    const zonesAndSubZones = await dispatch(getZonesAndSubZonesPromises())


Je me demande s'il ne vaut pas mieux garder Promise.all, pour des raisons de performances

getZonesAndSubZonesPromises() utilise lui-même un Promise.all() maintenant ^^. Il faut que je le renomme en getZonesAndSubZones() d'ailleurs.

…regulation

louptheron · 2024-11-29T13:27:22Z

Je note quelques retours ici :

Je n'arrive pas à décocher la zone admin. "ZEE" (elle était déjà côchée chez moi).
Dans la liste des navires, sur le filtre "Filtrer avec une zone existante": le 1er élément de la liste est vide. C'est sûrement lié au refacto des groupes
Dans le backoffice, la carte affichée lorsqu'on clique sur l'oeil pour voir l'aperçu d'une zone dans le formulaire est trop petite en largeur
Dans le formulaire REG du backoffice, la section "Engins Réglementés" : l'ajout d'engins ne fonctionne pas

…ersistence

ivangabriele · 2024-11-29T17:09:42Z

frontend/src/features/Vessel/components/VesselList/VesselListFilters.tsx

          <MultiCascader
-            // TODO A deep copy is required to prevent error : "can't define property "parent": Object is not extensible"
-            data={zonesFilter.map(zone => JSON.parse(JSON.stringify(zone)))}
+            data={zonesFilterClone}


J'ai fixé ces data, ce qui fixe l'affichage du multicascader mais il y a une erreur qui existe aussi sur master et que je n'ai pas réussi à corriger en un temps raisonnable :

La sélection de zone ne fonctionne pas en dév j'ai l'impression :X.

sonarcloud · 2024-11-29T17:59:30Z

Quality Gate passed

Issues
4 New issues
112 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ivangabriele · 2024-11-29T17:59:59Z

frontend/cypress/e2e/back_office/regulation_form/creation.spec.ts

@@ -224,4 +224,80 @@ context('BackOffice > Regulation Form > Creation', () => {
    cy.get('[data-cy="tag-MERLU D\'EUROPE (HKE)"]').should('exist')
    cy.get('[data-cy="tag-Espèces eau profonde"]').should('exist')
  })
+
+  it('Should send the expected request when creating a regulation with a complex period', () => {


J'ai essayé d'écrire un test d'ajout de période "complexe" pour tester le request body (apparemment en XML) mais c'est un petit enfer de faire un input de date via Cypress dans ces composants de date-là. Du coup j'ai poussé mon commit en WIP, c'est clairement pas fini sorry :X.

ivangabriele changed the title ~~Tech - Migre la liste des règlementations du BackOffice vers TS~~ Tech - Migre la liste des règlementations du BackOffice vers Typescript Oct 18, 2024

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from cecdcdc to f042650 Compare October 18, 2024 07:12

ivangabriele added bug Something isn't working tech. enhancement technical ehancement labels Oct 18, 2024

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from f042650 to b5ef849 Compare October 31, 2024 06:26

louptheron mentioned this pull request Oct 31, 2024

Signalements – Revoir le mode d'archivage des alertes "FAR 48h" #3806

Open

1 task

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from 1651c81 to 8500330 Compare November 7, 2024 09:50

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from 8500330 to 9b5ed99 Compare November 21, 2024 12:51

ivangabriele mentioned this pull request Nov 21, 2024

fix(hooks): add window definition guard to NewWindowContext MTES-MCT/monitor-ui#1472

Merged

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from ef6e2ba to 6af70f3 Compare November 26, 2024 15:30

louptheron reviewed Nov 28, 2024

View reviewed changes

frontend/src/features/AdministrativeZone/components/AdministrativeZones/index.tsx Outdated Show resolved Hide resolved

louptheron reviewed Nov 28, 2024

View reviewed changes

frontend/src/features/AdministrativeZone/layers/AdministrativeLayers.tsx Outdated Show resolved Hide resolved

louptheron reviewed Nov 28, 2024

View reviewed changes

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from ba7d6fe to ccfbc0d Compare November 28, 2024 15:43

ivangabriele added 16 commits November 29, 2024 12:22

Migrate backoffice regulation list to TS [WIP]

637a7b6

Rename all jsx files to tsx in frontend/src/features/BackOffice/edit_…

6a22c06

…regulation

Finalize BackOffice regulations migration to TS

1d820c4

Fix last prefer-nullish-coalescing ESLint rule issues

bc005eb

Elevate ESLint prefer-nullish-coalescing rule from warn to error

344ac72

Lint stage names case in App dockerfile

f109895

Migrate more JS file to TS and start typing regulation features

c8582d4

Remove legacy npm command test:lint:partial

d5fe33a

Remove unused Github workflows

49f5fe5

Update Redux typings

277b42b

Merge back regulation slice into a single slice for both stores

8adcdee

Remove duplicated webworker build

d6f28e8

Fix undefined window eager evaluation from NewWindowContext

c17efb5

Accept nullable geometry in mapToRegulatoryZone() util

59226bb

Move backoffice Regulation features into Regulation components

4bc304e

Merge Layer, BaseMap & domain map into MainMap feature

1272e70

ivangabriele added 8 commits November 29, 2024 12:22

Fix administrative layers not showing when selected

819aafd

Fix unhandled undefined mapping when loading admin layers

b2bcb79

Optimize <Map /> renders by tracking mouse position in slice

5638f1e

Fix regulation search via drawn shape

16a482d

Rename getZonesAndSubZonesPromises() to getZonesAndSubZones()

db91071

Fix GeoServer url for local run in regulatory layers e2e tests

939b2a1

Fix DayPicker in RegulationForm

938a6aa

Fix species group addition in regulation form

7c286f6

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from b286ea0 to 7c286f6 Compare November 29, 2024 11:22

ivangabriele added 6 commits November 29, 2024 12:26

Unwrap double dispatch in AdministrativeZones

dacabe7

Remove useless isBackoffice check in AdministrativeLayers

c6130ef

Lint SonarCloud issues

4ab0097

Fix default authorized/unauthorized value in SpeciesRegulationDisplayed

1af4498

Remove NamespaceContext from FrontEnd

a0d44c2

Wait 500ms for button animation end in mission layer toggle e2e test

5e7061c

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from d794064 to aefc9ed Compare November 29, 2024 12:17

Fix service-worker.js bundling via Vite

4b44b2c

ivangabriele force-pushed the ivan/migrate-backoffice-regulation-list-to-ts branch from aefc9ed to 4b44b2c Compare November 29, 2024 12:23

ivangabriele removed the bug Something isn't working label Nov 29, 2024

ivangabriele added 2 commits November 29, 2024 13:42

Force button clicks in mission layer toggle e2e test

02548c6

Fix wrong dom depth key in SpeciesRegulation

e8d6318

ivangabriele added 4 commits November 29, 2024 14:50

Fix wrong parentheses condition in regulation form RegulatedGears

2b9e812

Fix null to undefined backward compatibility for reg & admin layers p…

db7f8b5

…ersistence

Remove AdministrativeLayers from RegulationTables render

908f0cf

Fix zone filter multicascader data in main window vessel list

cf02e0d

ivangabriele commented Nov 29, 2024

View reviewed changes

Add regulation form e2e test for complex period input [WIP]

de2fe7d

ivangabriele commented Nov 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tech - Migre la liste des règlementations du BackOffice vers Typescript #3777

Tech - Migre la liste des règlementations du BackOffice vers Typescript #3777

ivangabriele commented Oct 17, 2024 •

edited

Loading

louptheron Nov 28, 2024

ivangabriele Nov 28, 2024 •

edited

Loading

louptheron commented Nov 29, 2024 •

edited by ivangabriele

Loading

ivangabriele Nov 29, 2024 •

edited

Loading

sonarcloud bot commented Nov 29, 2024

ivangabriele Nov 29, 2024 •

edited

Loading

Tech - Migre la liste des règlementations du BackOffice vers Typescript #3777

Are you sure you want to change the base?

Tech - Migre la liste des règlementations du BackOffice vers Typescript #3777

Conversation

ivangabriele commented Oct 17, 2024 • edited Loading

Linked issues

louptheron Nov 28, 2024

Choose a reason for hiding this comment

ivangabriele Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

louptheron commented Nov 29, 2024 • edited by ivangabriele Loading

ivangabriele Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Nov 29, 2024

Quality Gate passed

ivangabriele Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

ivangabriele commented Oct 17, 2024 •

edited

Loading

ivangabriele Nov 28, 2024 •

edited

Loading

louptheron commented Nov 29, 2024 •

edited by ivangabriele

Loading

ivangabriele Nov 29, 2024 •

edited

Loading

ivangabriele Nov 29, 2024 •

edited

Loading