remove inline css #372
remove inline css #372
Conversation
| } | ||
| meter.progress::-moz-meter-bar { | ||
| background: var(--primary); | ||
| } |
There was a problem hiding this comment.
I tested this in firefox and chrome, but still this is all hacky and brittle. IMHO we could also use <meter> without bootstrap styling.
There was a problem hiding this comment.
How hacky and brittle is it? Like in what way does it break? I think if it mostly works and "breaks" by falling back to a more default styling, that would probably be okay?
There was a problem hiding this comment.
I think it is unlikely that this breaks in a way that affects other elements on the page, but it could well be that the relevant part of the bar is not colored.
I would feel safer with reverting d2060da. However, other people tent to value esthetics higher than I do.
There was a problem hiding this comment.
I'll try to also test it in safari and maybe edge. If it also works there, I'd just go ahead with it and deploy it. the bar isn't used a lot and also has numbers on it, so even if it breaks it would be noticeable and we could still make changes.
This removes the last traces of inline style so the CSP can restricted and the application gets a bit more secure. See also #241