Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate HDF5 data location bug #391

Open
ascourtas opened this issue Aug 1, 2023 · 2 comments
Open

Investigate HDF5 data location bug #391

ascourtas opened this issue Aug 1, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ascourtas
Copy link
Contributor

ascourtas commented Aug 1, 2023

As a Data Consumer, I want to ensure the data files for the datasets I download all go to the same general location.

Jingrui has found a bug where for some reason extra copies of HDF5 files only are downloaded to ./data in addition to their proper locations. This isn't a game-breaking bug, but is untidy and should be resolved.

Track down the bug and resolve it such that all data go to the appropriate folders in the format /data/dataset_name_vx.x/

From Jingrui: "Here is one about downloading extra instance of data files that I just reported to Ben and I'd share the details here.
When downloading a dataset, Foundry should create directory and save the data at ./data/dataset_name_vx.x/ . While for the h5 datasets, mostly published by me and there's also one published by someone else, extra copies of the files are saved at ./data/ .
All the tabular datasets I tested are fine."

Image

Acceptance criteria

  1. The bug has been resolved and the data are only downloaded to the appropriate folder for that dataset, as described above
  2. The fix is released
  3. Jingrui has been alerted to the fix
@ascourtas ascourtas changed the title Investiate HDF5 data location bug Investigate HDF5 data location bug Aug 1, 2023
@kjschmidt913
Copy link
Contributor

Is this where the metadata conversation is coming from? If so, can someone rewrite this story? Or write a new one for it and add it to the sprint

@blaiszik
Copy link
Contributor

Is this error still occurring? I wonder the path fixes I made to https download fixed this. @Aristana @kjschmidt913

@kjschmidt913 kjschmidt913 added the bug Something isn't working label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants