Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judge school-based scratches stick if they change schools #271

Open
BenMusch opened this issue Oct 20, 2019 · 0 comments · May be fixed by #272
Open

Judge school-based scratches stick if they change schools #271

BenMusch opened this issue Oct 20, 2019 · 0 comments · May be fixed by #272

Comments

@BenMusch
Copy link
Member

Example:

  1. Someone just is accidentally assigned to the wrong school in R1 (imagine someone confuses Wellesley and Wesleyan, for example)

  2. R1 is paired with the wrong judge affiliation

  3. The affiliation is removed before R2

  4. R2 is paired

Expected behavior: The judge should have no scratches based on the old school assignment

Actual: All of the scratches stay the same

Fix:

  1. We need to distinguish between normal scratches and school affiliation ones, so we can remove them, so we should add another scratch type

  2. Every time a judge is saved, re-calculate the school scratches

@BenMusch BenMusch changed the title Judge school-based scratches stick if they chance schools Judge school-based scratches stick if they change schools Oct 20, 2019
@roddajohn roddajohn linked a pull request Oct 21, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant