Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data list search incorrectly shows filtered items #190

Open
BenMusch opened this issue May 6, 2019 · 0 comments
Open

Data list search incorrectly shows filtered items #190

BenMusch opened this issue May 6, 2019 · 0 comments

Comments

@BenMusch
Copy link
Member

BenMusch commented May 6, 2019

Because the tab.js file just calls show() and hide() on the DOM nodes when the search is run, things that were hidden due to filtering end up getting shown when they shouldn't be.

Can fix this by adding something like data-filtered and data-searched properties and showing/hiding based on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant