Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags returned when searching attributes #1302

Open
christianskou07 opened this issue Sep 19, 2024 · 2 comments
Open

Tags returned when searching attributes #1302

christianskou07 opened this issue Sep 19, 2024 · 2 comments

Comments

@christianskou07
Copy link

christianskou07 commented Sep 19, 2024

When searching attributes using search(controller='attributes', ...) it would be a valuable addition to have the option to filter which tags are included in the response. For example, do we want to have both global and local tags included, or only local tags.

In both cases, it might also prove beneficial to have the option to filter tags within each category to reduce the size of the response, e.g., say only local tags are requested, then include only the tag foo in the response.

One could also argue that in some scenarios, a less verbose version of the tags would be meaningful, e.g., include only specific details of each tag, such as its name.

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2024

PyMISP returns the content provided by MISP, and afaict, there is no way to only return a subset of the tags for specific attributes. Can you open a detailed issue of which features you want in the MISP project, with a reference to this one?

From PyMISP perspective, it makes little sense to strip the response once we get it back from MISP, it is the same as what you would be doing in your own code.

@christianskou07
Copy link
Author

Sure @Rafiot, I agree with you. Obviously, one could easily just process the response to include only what they want.

However, I find the option to at least only return local tags and/or a less verbose version of the tags to be useful, but yes, that definitely belongs in the MISP project to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants