Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts/download_datasets.py download BEIR datasets #13

Open
2 tasks done
Witiko opened this issue Mar 20, 2023 · 1 comment
Open
2 tasks done

Make scripts/download_datasets.py download BEIR datasets #13

Witiko opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Witiko
Copy link
Member

Witiko commented Mar 20, 2023

In Dockerfile, we call the script scripts/download_datasets.py that downloads all datasets to /var/tmp/pv211, so that the datasets are shared by all students that use JupyterHub, saving time and disk space. For example, here we download the ARQMath datasets: 1->2. Here, the students load them: 3->4->5.

Since #3, we've supported BEIR datasets. However, the BEIR datasets are not downloaded in Dockerfile and they are saved and loaded from the ./datasets directory, which slows down the students and duplicates disk space occupied.

Tasks

  • Download BEIR datasets to /var/tmp/pv211 in scripts/download_datasets.py.
  • Load BEIR datasets from /var/tmp/pv211 in pv211_utils.beir.loader.
@Witiko Witiko added the enhancement New feature or request label Mar 20, 2023
@Witiko
Copy link
Member Author

Witiko commented Mar 20, 2023

Since #1, we've had the pv211_utils.datasets module. However, the ArqmathDataset and TrecDataset classes hardcode the /var/tmp/pv211 path without a way to set it from the outside, which makes it more difficult to use pv211-utils as a general-purpose library outside the confines of the PV211 course.

Bonus tasks

  • Add optional cache_directory parameter to pv211_utils.datasets.ArqmathDataset.load_answers.
  • Add optional cache_directory parameter to pv211_utils.datasets.ArqmathDataset.load_questions.
  • Add optional cache_directory parameter to pv211_utils.datasets.TrecDataset.load_documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants