Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic protein identification with viewer.expandAndCollapseSelection(proteinIdentifier) #160

Open
EliotRagueneau opened this issue Nov 25, 2020 · 5 comments

Comments

@EliotRagueneau
Copy link

Currently, viewer.expandAndCollapseSelection(proteinIdentifier) uses the UniProt id to collapse or expand the proteins, but this is problematic on cases such as this one on intact-portal because both participants have the same identifier, but they are not the same participants.

Would there be a way to use IntAct participant's ac for this function instead, to avoid this problem? Or maybe se should add another parameter indicating which field complex viewer should be looking for among the participants to collapse/expand them? e.g. viewer.expandAndCollapseSelection(id, idType)

P.S.: I'm relatevily new to IntAct team, and began recently to work a bit on complex viewer, but you've done a really good job here @colin-combe, it's a really nice viewer. Thanks a lot for your help and support!

@colin-combe colin-combe self-assigned this Nov 25, 2020
@colin-combe
Copy link

viewer.expandAndCollapseSelection(id, idType)

yes, we can do that

@colin-combe
Copy link

@EliotRagueneau - hmm, I don't think I can find this Intact participant ac in the json the viewer recieves.
To see the json, I'm looking here: https://wwwdev.ebi.ac.uk/intact/ws/graph/interaction/export/EBI-7156290
It may need a change to the json? (or do you see it in there somewhwhere?)

@EliotRagueneau
Copy link
Author

You are absolutely right, we'll have to fix this! @noedelta maybe you could do that since you're currently working on the Complex Viewer?

@colin-combe
Copy link

i'll unassign myself since it can't be done until Intact participant ac is in the json

@colin-combe
Copy link

from meeting, plan is for @noedelta to add Intact participant ac to the json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants