-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problematic protein identification with viewer.expandAndCollapseSelection(proteinIdentifier) #160
Comments
yes, we can do that |
@EliotRagueneau - hmm, I don't think I can find this Intact participant ac in the json the viewer recieves. |
You are absolutely right, we'll have to fix this! @noedelta maybe you could do that since you're currently working on the Complex Viewer? |
i'll unassign myself since it can't be done until Intact participant ac is in the json |
from meeting, plan is for @noedelta to add Intact participant ac to the json |
Currently,
viewer.expandAndCollapseSelection(proteinIdentifier)
uses the UniProt id to collapse or expand the proteins, but this is problematic on cases such as this one on intact-portal because both participants have the same identifier, but they are not the same participants.Would there be a way to use IntAct participant's ac for this function instead, to avoid this problem? Or maybe se should add another parameter indicating which field complex viewer should be looking for among the participants to collapse/expand them? e.g.
viewer.expandAndCollapseSelection(id, idType)
P.S.: I'm relatevily new to IntAct team, and began recently to work a bit on complex viewer, but you've done a really good job here @colin-combe, it's a really nice viewer. Thanks a lot for your help and support!
The text was updated successfully, but these errors were encountered: