Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document assert_allclose and pytest.approx #234

Open
IAlibay opened this issue Oct 29, 2022 · 2 comments
Open

document assert_allclose and pytest.approx #234

IAlibay opened this issue Oct 29, 2022 · 2 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 29, 2022

Since these are the favoured assertion methods for the core library, we should document these in testing.rst.

@jandom
Copy link
Contributor

jandom commented Jul 26, 2023

This ticket sounds very similar to #171 – what's the difference? pytest.approch?

@IAlibay
Copy link
Member Author

IAlibay commented Jul 26, 2023

@jandom yeah the addition here is pytest.approx. MDAnalysis recommends using approx for single float comparisons and allclose for arrays (it's purely a speed thing, allclose on single numbers is very slow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants