Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise GFXR compiler-warning level #1890

Open
fabian-lunarg opened this issue Nov 27, 2024 · 0 comments
Open

Raise GFXR compiler-warning level #1890

fabian-lunarg opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.

Comments

@fabian-lunarg
Copy link
Contributor

fabian-lunarg commented Nov 27, 2024

we treat warnings as errors, but could/should be more strict.

  • e.g. we currently tolerate -Wshadow which can and will eventually manifest as real bugs.
  • a good example of where we want to go (at least for gcc) was given by this PR

this issue should track our progress for the transition and group related PRs.

the proposed strategy is as follows:

  • we defined a cmake-option USE_STRICT_COMPILER_WARNINGS which will enable stricter warnings
  • this option is meant to be only temporary, for the duration of the transition. the default is currently OFF
  • in multiple PRs we iterate on both the defined compiler-settings and gradually apply them to our framework
  • once applied to all code, we remove the option again and will use the strict settings as new default
@fabian-lunarg fabian-lunarg added the enhancement New feature or request label Nov 27, 2024
@bradgrantham-lunarg bradgrantham-lunarg added the P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.
Projects
None yet
Development

No branches or pull requests

2 participants