Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all fields are initialized even for kIsNull in Code gen #1775

Open
jzulauf-lunarg opened this issue Sep 27, 2024 · 0 comments
Open

Ensure all fields are initialized even for kIsNull in Code gen #1775

jzulauf-lunarg opened this issue Sep 27, 2024 · 0 comments
Assignees
@MarkY-LunarG
Labels
openxr-experimental Related to OpenXR experimental support P1 Prevents an important capture from being replayed

Comments

@jzulauf-lunarg
Copy link
Contributor

Currently (at least) DecodeNextStruct(..., OpenXrNextNode** next) doesn't initialize *next = nullptr; when format::PointerAttributes::kIsNull is set. When memory isn't zeroed, can cause access violations.

Decoding of kIsNull should assure correct setting of pointers to null
@jzulauf-lunarg jzulauf-lunarg added the openxr-experimental Related to OpenXR experimental support label Sep 27, 2024
@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkY-LunarG MarkY-LunarG

Labels
openxr-experimental Related to OpenXR experimental support P1 Prevents an important capture from being replayed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarkY-LunarG @jzulauf-lunarg @bradgrantham-lunarg