Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX12 Swapchain buffers' resource states could be wrong for trimming case. #1755

Open
locke-lunarg opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working capture Issue with capture d3d12 Issue with D3D 12 support P1 Prevents an important capture from being replayed replay Issue with replay (capture was successful) trimming Issue with trimming in capture or in replay

Comments

@locke-lunarg
Copy link
Contributor

locke-lunarg commented Sep 24, 2024

Now, during capture, only GFXRECON_CAPTURE_DRAW_CALLS case(#1680) writes swapchain buffers. The other trimmings, that frames and queue submits, don't write swapchain buffers. It also doesn't write their resource states (MetaDataType::kInitSubresourceCommand). In this case, during replay, swapchain buffers aren't initialized to the correct resource states. It could happen wrong resource state errors.

We could add a new MetaDataType, like kInitSwapchainResourceStatesCommand, to fix it. Or we could wait until the new architecture that replay could access capture to fix it.

@locke-lunarg locke-lunarg added bug Something isn't working capture Issue with capture replay Issue with replay (capture was successful) trimming Issue with trimming in capture or in replay d3d12 Issue with D3D 12 support labels Sep 24, 2024
@locke-lunarg locke-lunarg changed the title DX12 Swapchain buffers' resource states are wrong for trimming case. DX12 Swapchain buffers' resource states could be wrong for trimming case. Sep 24, 2024
@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working capture Issue with capture d3d12 Issue with D3D 12 support P1 Prevents an important capture from being replayed replay Issue with replay (capture was successful) trimming Issue with trimming in capture or in replay
Projects
None yet
Development

No branches or pull requests

2 participants