Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NN Descent Code typo error #35

Open
Heisenberg-Yin opened this issue Dec 27, 2023 · 0 comments
Open

NN Descent Code typo error #35

Heisenberg-Yin opened this issue Dec 27, 2023 · 0 comments

Comments

@Heisenberg-Yin
Copy link

Dear authors

I have a question regarding the ComponentRefineNNDescent::update() function in the component_refine.cpp file. In this function, there's a conditional statement nn.distance > nhood_o.pool.back().distance. I'm wondering if there's a possibility that this condition should instead be nn.distance < nhood_o.pool.back().distance. Could you please review and explain whether this change is appropriate or necessary?

Best Regards,
Ziqi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant