-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With amount of issues in project and in case of >1000 issues #132
Comments
If the problem is only in sql query with tons of And, may you provide details about your installation? In particular: name and version of DB for Redmine, total amount of issues in the Redmine and approximate size of |
Project has 9672 issues:
And so on 9672 times. Rendered plugins/redmine_issues_tree/app/views/issues_trees/_tree_list.html.erb (Duration: 287013.7ms | Allocations: 305556808) Duration: 287013.7ms !!! When we change string on data-tt-branch="<%= issue.children? ? 'true' : 'false' %>"
Rendered plugins/redmine_issues_tree/app/views/issues_trees/_tree_list.html.erb (Duration: 3151.3ms | Allocations: 2889765) |
As an option /app/views/issues_trees/_tree_list.html.erb
replaced by
app/views/issues_trees/_tree_node.html.erb
|
@lyollix this is a good idea to not load big nodes! The threshold can be specified in the settings. And in ideal case, we can show somethind else (not arrow) for such big nodes. May you create a PR with the changes? I'll test it, add settings and distribute across all supported version. |
We have many projects with > 1000 tasks, the plugin constantly freezes for an indefinite time, it is almost impossible to use the plugin, but I would really like to.
For us, the solution was to replace
in file
app/views/issues_trees/_tree_node.html.erb
string
data-tt-branch="<%= issue.children.where(id: issues_ids).any? ? 'true' : 'false' %>"
on
string
data-tt-branch="<%= issue.children? ? 'true' : 'false' %>"
At the same time, the speed is excellent, but triangles appear if the parent has children at all.
However, if some filters are applied, the triangle is still there, but there are no children there.
For us it was still a good decision.
Could you include in the implementation some more generic solution based on ours?
The text was updated successfully, but these errors were encountered: