From cac1ca4c648d13bc5fa832038e10b2c38e012c84 Mon Sep 17 00:00:00 2001 From: marionbarker Date: Sun, 13 Oct 2024 20:10:31 -0700 Subject: [PATCH 1/4] warn against deleting an app --- docs/browser/bb-errors.md | 26 +++++++++++++++++++++++++- docs/browser/other-apps.md | 13 ++++++++++++- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/docs/browser/bb-errors.md b/docs/browser/bb-errors.md index 4a1ac2f5a07..148c9440c28 100644 --- a/docs/browser/bb-errors.md +++ b/docs/browser/bb-errors.md @@ -48,7 +48,6 @@ These are some of the most common errors to date. * You can delete any branch that starts with the name `alive` and try again * See [Automatic Creation of `alive branch`](automatic.md#automatic-creation-of-alive-branch){: target="_blank" } - ## Error Annotations Error annotations are available for the *Loop* app released version 3.4 and later. These were contributed by community volunteers along with the improvements to enable automatic updates and automatic builds. @@ -188,6 +187,31 @@ Click on the top link to view the record of the failed action as shown in the gr As your *GitHub* `username` is case-sensitive, use copy and paste. +## Do Not Remove an App + +Please do not remove an existing app if you have trouble building a different app. Your build error is not caused by any existing app. + +!!! Important "Remove App Warning" + If you remove an app and later want to restore that app, you might not be able to. + + Sad and Expensive Scenario: + + 1. User removed app with name "My App" and unique bundle ID that includes their TEAMID + 1. User later decided to restore their app, but in the meantime, someone else has used the name "My App" + 1. When trying to restore your app, Apple doesn't allow you to change just the name of the app and will not allow you to restore it because someone else has that name, even though your bundle ID is different + 1. After spending time on the phone with Apple, user's only option was to purchase a new Apple Developer account so they can get a new TEAMID (see steps below) or doing a custom change to the Loop code to modify the bundle ID (no instructions are provided for this - easy to do it wrong) + +### New Developer ID with Same GitHub Account + +You can use the same GitHub account with a new developer ID. Here are the steps: + +1. Update the 4 secrets that are associated with the Apple Account for each repository on the GitHub used for browser build: + * TEAMID + * FASTLANE_ISSUER_ID + * FASTLANE_KEY_ID + * FASTLANE_KEY +1. Once the Secrets are updated, start at the [Identifiers](identifiers.md){:target="_blank"} page and work through the process for each app + ## Action: `Validate Secrets` Errors For Version 3.4 and later - use [Examine Annotation](#examine-annotation) and read the annotation. diff --git a/docs/browser/other-apps.md b/docs/browser/other-apps.md index dca138ec5ea..d4edab10a57 100644 --- a/docs/browser/other-apps.md +++ b/docs/browser/other-apps.md @@ -147,7 +147,6 @@ The `Validate Secrets`  Action  should * [Action: Validate Secrets Errors](bb-errors.md#action-validate-secrets-errors){: target="_blank" } tells you what to search for in the file * Resolve the error and repeat the Action: [Validate Secrets](#validate-secrets) - ## Add Identifiers Near the top middle of your Repository fork, click on the "Actions" tab. @@ -384,6 +383,18 @@ Refer to the graphic below for the first four steps: 1. If the process appears to be happening without an error, go do something else for a while. The build should take about 20-30 minutes. 1. Your app should eventually appear on [App Store Connect](https://appstoreconnect.apple.com/apps){: target="_blank" }. +### Build Errors + +Refer to the [Browser Build: Build Errors](bb-errors.md){: target="_blank" } to find your error. + +Please do not remove an existing app if you have trouble building a new one. Your build error is not cause by any existing app. + +!!! Important "Removing App Warning" + If you remove an app and later want to restore that app, you might not be able to. + + For more information, see [Do Not Remove an App](bb-errors.md#do-not-remove-an-app){: target="_blank" }. + + ## Add Users to *TestFlight* for App Once the first build completes, you will be able to configure *TestFlight* for the app - follow the template for setting up *TestFlight* for Loop found in [Configure to Use Browser: Set Up Users and Access (TestFlight)](../browser/tf-users.md#set-up-users-and-access-testflight). From b2c0ae5330d54f2b88f885cec6935c7852feeee5 Mon Sep 17 00:00:00 2001 From: marionbarker Date: Sun, 13 Oct 2024 21:24:55 -0700 Subject: [PATCH 2/4] update graphic for 3.4.4 --- docs/version/img/app-version.svg | 7903 ++++++++++++++++++++++++------ 1 file changed, 6484 insertions(+), 1419 deletions(-) diff --git a/docs/version/img/app-version.svg b/docs/version/img/app-version.svg index 31fe33d8c63..f6b6fce2ea6 100644 --- a/docs/version/img/app-version.svg +++ b/docs/version/img/app-version.svg @@ -1,8 +1,8 @@ From 08468a0edda83411523cd60892d9517288004f1f Mon Sep 17 00:00:00 2001 From: marionbarker Date: Sun, 13 Oct 2024 21:28:27 -0700 Subject: [PATCH 3/4] update pages for release 3.4.4 --- docs/build/computer.md | 4 ++-- docs/build/xcode-version.md | 4 ++-- docs/version/releases.md | 15 +++++++++++++-- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/docs/build/computer.md b/docs/build/computer.md index 0eb592b60dc..eeeb8b186e4 100644 --- a/docs/build/computer.md +++ b/docs/build/computer.md @@ -46,9 +46,9 @@ The current release of _Loop_  requires Xc When this page was last updated, macOS 14.6 and Xcode 15.4 were tested to successfully build the app for phones with iOS 15 through iOS 18.0.1. Newer versions, macOS 15 and Xcode 16 work as well. -> Release 3.4.2 and newer fix an issue building *Loop* with Xcode 16. If your current *Loop* app does not show your expiration date, please rebuild to version 3.4.3 as soon as possible. +> Release 3.4.2 and newer fix an issue building *Loop* with Xcode 16. If your current *Loop* app does not show your expiration date, please rebuild to version 3.4.4 as soon as possible. -The table below lists the **minimum** requirements to build the current release of Loop 3.4.3. If your macOS or Xcode version is higher, you can build with *Mac*. +The table below lists the **minimum** requirements to build the current release of Loop 3.4.4. If your macOS or Xcode version is higher, you can build with *Mac*. Find your phone iOS in the table below. If your iOS is not listed, e.g., 17.6.1, choose the first row that is less than your iOS. diff --git a/docs/build/xcode-version.md b/docs/build/xcode-version.md index 6cd28ce9b01..8ea9cdd96f5 100644 --- a/docs/build/xcode-version.md +++ b/docs/build/xcode-version.md @@ -85,9 +85,9 @@ The current release of _Loop_  requires Xc When this page was last updated, macOS 14.6 and Xcode 15.4 were tested to successfully build the app for phones with iOS 15 through iOS 18.0.1. Newer versions, macOS 15 and Xcode 16 work as well. -> Release 3.4.2 and newer fix an issue building *Loop* with Xcode 16. If your current *Loop* app does not show your expiration date, please rebuild to version 3.4.3 as soon as possible. +> Release 3.4.2 and newer fix an issue building *Loop* with Xcode 16. If your current *Loop* app does not show your expiration date, please rebuild to version 3.4.4 as soon as possible. -The table below lists the **minimum** requirements to build the current release of Loop 3.4.3. If your macOS or Xcode version is higher, you can build with *Mac*. +The table below lists the **minimum** requirements to build the current release of Loop 3.4.4. If your macOS or Xcode version is higher, you can build with *Mac*. Find your phone iOS in the table below. If your iOS is not listed, e.g., 17.6.1, choose the first row that is less than your iOS. diff --git a/docs/version/releases.md b/docs/version/releases.md index e9d491dbbee..dc0b8c08760 100644 --- a/docs/version/releases.md +++ b/docs/version/releases.md @@ -6,7 +6,7 @@ For information about version 2 releases and compatibility between version 2 and ## Current Release -The current released version for the *Loop* app is 3.4.3. The dates and contents for releases are summarized below in reverse chronological order (so newest release information comes first). +The current released version for the *Loop* app is 3.4.4. The dates and contents for releases are summarized below in reverse chronological order (so newest release information comes first). ### What Version Do I Have? @@ -23,16 +23,27 @@ Additional information including links is found here, but be aware that updates ## Loop 3 Version History +### Loop v3.4.4 + +*Loop* v3.4.4 restored the TestFlight expiration date for Browser Build - it was released twice with the same build number. Just make sure your build (for both Browser Build and Mac Build) are later than 12 October 2024. + +* The first release on 9 October 2024 inadvertently removed all the improvements from v3.4.3, but did fix the TestFlight expiration date +* The second release on 12 October 2024 restored the improvements from v3.4.3 + +* [Link to release notes for Loop 3.4.4](https://github.com/LoopKit/Loop/releases/tag/v3.4.4){: target="_blank" } + ### Loop v3.4.3 *Loop* v3.4.3 was released on 6 October 2024. +A few days later, it was discovered that the TestFlight expiration date was no longer available for Browser Build. This was quickly remedied with the *Loop* 3.4.4 release. + This was a minor update to the *Loop* code with a few bug fixes and some capability extensions. !!! important "Please use the `main` branch" Some people have become complacent about using the `dev` branch to get the latest updates. This is a good time to switch to the `main` branch. - New revision will be landing in the `dev` branch soon. Don't be surprised - stick with `main` and version 3.4.3 until the changes have been tested. + New revision will be landing in the `dev` branch soon. Don't be surprised - stick with `main` until the changes have been tested. * [Link to release notes for Loop 3.4.3](https://github.com/LoopKit/Loop/releases/tag/v3.4.3){: target="_blank" } From f4b3688d070fcad68d0798ee16ec421c5dd49ca4 Mon Sep 17 00:00:00 2001 From: marionbarker Date: Sun, 13 Oct 2024 21:38:13 -0700 Subject: [PATCH 4/4] add loss of expiration date for browser build to 3.4.2 information --- docs/version/releases.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/version/releases.md b/docs/version/releases.md index dc0b8c08760..7ea3b10e306 100644 --- a/docs/version/releases.md +++ b/docs/version/releases.md @@ -36,7 +36,7 @@ Additional information including links is found here, but be aware that updates *Loop* v3.4.3 was released on 6 October 2024. -A few days later, it was discovered that the TestFlight expiration date was no longer available for Browser Build. This was quickly remedied with the *Loop* 3.4.4 release. +A few days later, it was discovered that the TestFlight expiration date was no longer available for Browser Build (due to a change in 3.4.2). This was quickly remedied with the *Loop* 3.4.4 release. This was a minor update to the *Loop* code with a few bug fixes and some capability extensions. @@ -76,7 +76,7 @@ The Browser Build method was updated to use `Fastlane version 2.223.1`. This cha *Loop* v3.4.2 was released on 5 October 2024. -This was a patch that fixed errors with the expiration date for the Mac-Xcode build method for Xcode 16. No other changes were made. Because Browser Builders all use Xcode 15.4, there was no problem with their expiration date reporting. +This was a patch that fixed errors with the expiration date for the Mac-Xcode build method for Xcode 16. No other changes were made. Unfortunately, the method used to fix expiration date for Mac Xcode 16 builders removed the expiration date for Browser Builders. The expiration date for Browser Builders was restored with version 3.4.4. * [Link to release notes for Loop 3.4.2](https://github.com/LoopKit/Loop/releases/tag/v3.4.2){: target="_blank" }