Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adjustment request: AOE damage abilities display their enabling promotion name #11469

Closed
Tekamthi opened this issue Dec 29, 2024 · 4 comments

Comments

@Tekamthi
Copy link

Tekamthi commented Dec 29, 2024

There's a number of AOE damage abilities in the promo table... Several of these always display a message when activated "pilum", "rend", etc. One of them doesn't have any message, just the damage value.

When using these abilities via another promotion, it is undesirable for them to display "rend" or "pilum" etc. The ideal would be to just dynamically display the name of the promotion that enables these abilities, and for it to work consistently this way across all similar abilities. If this is too complicated/costly, displaying just the damage value would be preferable to the misleading names in status quo

@azum4roll
Copy link
Collaborator

It's not possible to get the promotion that has already applied the effect to the unit (what if there are two of them?)

One of them doesn't have any message, just the damage value.

All of them have a name (Pilum, Rend, Viking, Splash Damage, Area Damage). We can change them to "Fortify Area Damage", but that's too long...

@Tekamthi
Copy link
Author

Tekamthi commented Dec 30, 2024

okay thanks for considering, i'll close this one -- since posting i've discovered they're just text tags like any other and can be overwritten anyway -- i used "fortify" and "move" to indicate the cause -- but if theres only one source for each in the mod by default then the labels make sense

edit: there is one more that doesn't have a name: NearbyEnemyDamage -- if it sits unused then it doesn't matter, but idk if its even linked to a name the way the others are

@azum4roll
Copy link
Collaborator

azum4roll commented Dec 30, 2024

NearbyEnemyDamage is an end-of-turn effect, not a type of AOE damage. It works however Citadels work.

@Tekamthi
Copy link
Author

yes thats right, however from general player perspective it appears to work as somewhat of a variant of the other aoe effects -- for example the fortify aoe is almost like its start-of-turn counterpart

@Tekamthi Tekamthi reopened this Dec 30, 2024
@Tekamthi Tekamthi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants