Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prophecy halving of follower reduction doesn't work #11355

Open
gamask opened this issue Nov 7, 2024 · 1 comment
Open

prophecy halving of follower reduction doesn't work #11355

gamask opened this issue Nov 7, 2024 · 1 comment

Comments

@gamask
Copy link

gamask commented Nov 7, 2024

1. Mod Version (4.15.2). Current Version: 4.16.2

3. List of Other Mods
InfoAddict (v 22)
Really Advanced Setup (v 15)
UI - Military Log (v 2)
UI - Promotion Tree for VP
UI - Small Resource Icons (v 4)

4. Describe the Issue
Enemy prophet removes all of my followers from a city that has my majority religion with prophecy belief.
Supposed to remove only half.

Looks to me like there are two separate issues happening.
One is that m_iInquisitorPressureRetention is never set to anything other than 0, at least nowhere that I could find.
Two is that CvReligionBeliefs::GetInquisitorPressureRetention will ignore a non-0 value anyway due to isBeliefValid returning false.
Apparently prophecy doesn't work in cities belonging to someone other than the founder.
I don't know if that is intended, but it could be argued that it is not.
The belief is supposed to apply to inquisitors as well, and it's impossible for someone else to use an inquisitor on your city.
So I believe the intent is to make it harder for rival inquisitors to remove your religion from their cities, in which case prophecy must work in cities of non-founders, or it makes no sense.


5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)
otto prophet.zip

8. Steps to reproduce the Issue (Optional)

Find the Ottoman prophet in the middle of American land.
Convert Los Angeles.
Observe that it removes all followers.
I'm Ethiopia in this game. I have prophecy, and Los Angeles has my religion as majority.
I used the observer mode to swap to Ottomans.

@azum4roll
Copy link
Collaborator

One is that m_iInquisitorPressureRetention is never set to anything other than 0, at least nowhere that I could find.

It's set to 50 for Prophecy.

Two is that CvReligionBeliefs::GetInquisitorPressureRetention will ignore a non-0 value anyway due to isBeliefValid returning false.

By default, founder and enhancer beliefs only work for whoever owning the holy city. It may work against someone who conquers the holy city from the original founder (making it harder to get rid of the religion), but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants