Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todo.ejs #239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update todo.ejs #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647add3
Update todo.ejs
mazhar1976 Nov 18, 2024
bd69d75
Update todo.ejs
mazhar1976 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/todo.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
</head>

<body>
<h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1>
<h1>Hello Junoon Batch 8 (Jenkins), This is best time to Learn Jenkins & spread knowledge across the world on Jenkins</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Further improve the header message

The current message is repetitive and could be more impactful with better structure.

Consider this improvement:

-        <h1>Hello Junoon Batch 8 (Jenkins), This is best time to Learn Jenkins & spread knowledge across the world on Jenkins</h1>
+        <h1>Hello Junoon Batch 8: Now is the perfect time to master Jenkins and share your expertise globally! 🚀</h1>

The suggested changes:

  • Simplified the structure while maintaining enthusiasm
  • Removed redundant mentions of Jenkins
  • Added an emoji for visual appeal
  • Made the message more professional and motivational
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<h1>Hello Junoon Batch 8 (Jenkins), This is best time to Learn Jenkins & spread knowledge across the world on Jenkins</h1>
<h1>Hello Junoon Batch 8: Now is the perfect time to master Jenkins and share your expertise globally! 🚀</h1>

<ul>
<% todolist.forEach(function(todo, index) { %>
<li>
Expand Down