Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

setSendRawLogMessage(...) doesn't work #67

Open
rwtaylorjr opened this issue May 10, 2018 · 0 comments
Open

setSendRawLogMessage(...) doesn't work #67

rwtaylorjr opened this issue May 10, 2018 · 0 comments

Comments

@rwtaylorjr
Copy link

The new feature for sending raw log messages doesn't work.
This is because changes in the sendRawLogMessage in the parent don't propagate downstream as arguments are passed by value and the sendRawLogMessage is a boolean primitive.

For example:
AndroidLogger logger = AndroidLogger.createInstance(…);

  • Creates a new instance of AsyncLoggingWorker which subsequently creates a new instance
 of SocketAppender with a copy of the current value of false for sendRawLogMessage.


Later i invoke logger.setSendRawLogMessage(true);
Since arguments are passed by value and Java primitives are not object references then even though
 I have set the sendRawLogMessage value in AsyncLoggingWorker, the copy in SocketAppender is not
affected and remains false.

Therefore, even though I have told AndroidLogger to send raw logging message, it is still decorating it.

I commented on this issue in 64a275a but never heard back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant