Provide support for multiple accounts, add a new state module
#48
Conversation
✅ Deploy Preview for admirable-pika-22aea5 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
|
|
||
| @db_wrapper | ||
| def update_market( |
There was a problem hiding this comment.
Function update_market has 7 arguments (exceeds 6 allowed). Consider refactoring.
There was a problem hiding this comment.
It only has 6, though?
|
|
||
|
|
||
| @db_wrapper | ||
| def select_markets( |
There was a problem hiding this comment.
Function select_markets has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
|
|
||
| @lru_cache | ||
| @db_wrapper | ||
| def select_account( |
There was a problem hiding this comment.
Function select_account has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 565b77f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 58.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.2% (-1.2% change). View more on Code Climate. |
LivInTheLookingGlass
added
enhancement
|
|
||
|
|
||
| @db_wrapper | ||
| def update_market( |
There was a problem hiding this comment.
Function update_market has 8 arguments (exceeds 6 allowed). Consider refactoring.
|
|
||
|
|
||
| @db_wrapper | ||
| def update_market( |
There was a problem hiding this comment.
Function update_market has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
This will merge after I add a few tests and merge the production databases |
| assert db is not None | ||
| params: tuple[Any, ...] = () | ||
| q_additions = [] | ||
| for name, value in { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| query = "from accounts select id, raw_account, account, is_encrypted where " | ||
| params: tuple[Any, ...] = () | ||
| q_additions = [] | ||
| for name, value in { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
No description provided.