Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pow support #161

Merged
merged 14 commits into from
Jun 14, 2024
Merged

Feat/pow support #161

merged 14 commits into from
Jun 14, 2024

Conversation

hunjixin
Copy link
Contributor

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

pkg/web3/sdk.go Outdated Show resolved Hide resolved
pkg/web3/sdk.go Outdated Show resolved Hide resolved
pkg/web3/types.go Outdated Show resolved Hide resolved
import { HardhatRuntimeEnvironment } from 'hardhat/types'
import { DeployFunction } from 'hardhat-deploy/types'

const deployUsers: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to deployPow

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AquiGorka AquiGorka merged commit a08786c into main Jun 14, 2024
2 checks passed
@AquiGorka AquiGorka deleted the feat/pow_support branch June 14, 2024 22:02
noryev pushed a commit that referenced this pull request Jun 17, 2024
* feat: power implementation

* feat: simplly code

* chore: add a explain comment for target difficulty

* fix typo

* fix: blocked error channel

* chore: update dev toml sc address

* feat: change wrong log and add toml tag

* fix: upgrade cowsay to v0.0.4

* fix: update devent controller address

* fix: Add POW config processor

* feat: add pow address for testnet

* chore: update to latest controller address

* chore: update contract addresses

* build: add hardhat testnet config

---------

Co-authored-by: root <[email protected]>
Co-authored-by: hunjixin <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Gorka <[email protected]>
Co-authored-by: Arsen Yeremin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants