From 6d4b0deed70a4729aa96be9e5843e8df62ea3e33 Mon Sep 17 00:00:00 2001 From: Luca Antiga Date: Tue, 16 Apr 2024 08:38:50 -0400 Subject: [PATCH 1/2] Temporarily skip thunder test due to timeout --- tests/test_thunder_fsdp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test_thunder_fsdp.py b/tests/test_thunder_fsdp.py index 8b9c0f4340..baa895a9a1 100644 --- a/tests/test_thunder_fsdp.py +++ b/tests/test_thunder_fsdp.py @@ -261,6 +261,7 @@ def set_up_planner(self, state_dict, metadata, is_coordinator): return state_dict +@pytest.skip("Temporarily disabled, often exceeds 5 min timeout") @RunIf(min_cuda_gpus=2, thunder=True, standalone=True) def test_save_load_sharded_checkpoint(tmp_path): strategy = ThunderFSDPStrategy(state_dict_type="sharded", broadcast_from=0) From e1a180ba19f1e4b1bf366027a622e8fec5a8bea8 Mon Sep 17 00:00:00 2001 From: Luca Antiga Date: Tue, 16 Apr 2024 09:10:46 -0400 Subject: [PATCH 2/2] Move skip inside test --- tests/test_thunder_fsdp.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_thunder_fsdp.py b/tests/test_thunder_fsdp.py index baa895a9a1..321cdac7a6 100644 --- a/tests/test_thunder_fsdp.py +++ b/tests/test_thunder_fsdp.py @@ -261,9 +261,10 @@ def set_up_planner(self, state_dict, metadata, is_coordinator): return state_dict -@pytest.skip("Temporarily disabled, often exceeds 5 min timeout") @RunIf(min_cuda_gpus=2, thunder=True, standalone=True) def test_save_load_sharded_checkpoint(tmp_path): + pytest.skip("Temporarily disabled, often exceeds 5 min timeout") + strategy = ThunderFSDPStrategy(state_dict_type="sharded", broadcast_from=0) fabric = Fabric(accelerator="cuda", devices=2, strategy=strategy) fabric.launch()