Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistralai/Mistral-7B-v0.3 support #1444

Closed
karkeranikitha opened this issue May 25, 2024 · 4 comments · Fixed by #1486
Closed

mistralai/Mistral-7B-v0.3 support #1444

karkeranikitha opened this issue May 25, 2024 · 4 comments · Fixed by #1486

Comments

@karkeranikitha
Copy link

When will finetuning support for mistralai/Mistral-7B-v0.3 be integrated?

@rasbt
Copy link
Collaborator

rasbt commented May 25, 2024

Sorry, I don't have an ETA at the moment as there are some other things on the list first. By the way, I started it here #1431 but then noticed that there are some new weights (or weight naming conventions) compared to v0.2 that I'd have to look into further to make it work.

@karkeranikitha
Copy link
Author

ok thank you.

@davmacario
Copy link
Contributor

noticed that there are some new weights (or weight naming conventions) compared to v0.2

I did notice that too! It is strange, though, as the 'model.safetensors.index.json' file in the huggingface repo uses the usual weight names...

@davmacario
Copy link
Contributor

@rasbt One other thing I noticed is that if the downloading script decides to use Safetensors, it will not download the 'model.safetensors.index.json', as its name does not match "*.safetensors", as specified at this line.

Shouldn't that line contain:

download_files.append("*.safetensors*")

instead (similarly to what done if downloading .bin files here), or is that the desired behavior?

I can put together a tiny PR if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants