Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check-in button on reservation page only shows for admins #457

Open
njm506 opened this issue Nov 18, 2024 · 0 comments · May be fixed by #458
Open

Check-in button on reservation page only shows for admins #457

njm506 opened this issue Nov 18, 2024 · 0 comments · May be fixed by #458

Comments

@njm506
Copy link

njm506 commented Nov 18, 2024 •
edited
Loading

Affects 2.8.6.2

Regular users are unable to check-in on the Edit Reservation page (where the email links to), but they can check in from the dashboard. This is due to an error in the logic (PR to follow):

{if $CheckInRequired && (!checkinAdminOnly || $CanViewAdmin)}

Compiles down to:

<?php
  if (
    $_smarty_tpl->tpl_vars['CheckInRequired']->value &&
    (!'checkinAdminOnly' || $_smarty_tpl->tpl_vars['CanViewAdmin']->value)
  ) {?>

There is a missing $, so a string is used, which always evaluates to true (so the ! always evaluates to false).
njm506 added a commit to njm506/librebooking that referenced this issue Nov 18, 2024
@njm506
Fix checkin/out button on Reservation page
cb91973 
Missing `$` in template was causing the buttons to only show for
administrators.

Fixes LibreBooking#457
@njm506 njm506 linked a pull request Nov 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checkin/out button on Reservation page njm506/librebooking
1 participant
@njm506