Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Combined Layer Assets Again (Pirate/Christmas Hats) #42

Open
jrconway3 opened this issue Jan 3, 2025 · 2 comments
Open

Add Combined Layer Assets Again (Pirate/Christmas Hats) #42

jrconway3 opened this issue Jan 3, 2025 · 2 comments
Assignees

Comments

@jrconway3
Copy link
Contributor

jrconway3 commented Jan 3, 2025

I've been considering this ever since I added the pirate hats to the remaining frames, but I don't think having the thatching and pirate hat trim as separate layers only is good for usability.

Having the trim layers get a separate entry for Alt Colors is probably fine, but by default I think they should probably be combined layers. I do have the original "combined asset" as a separate asset in the repo that's unused, so we can run with that.

That said, any other suggestions are welcome. I feel like I went overboard adding these trims as fully separate layers anyway, but I didn't have an easy way to add alt colors without doing so... the original versions by bluecarrot16 had 3 colors each for the trim, along with the main hat still having all the standard recolors.

Same goes for the Christmas Hats, too. We should have the base layer with the white trim, then have recolors as an overlay option.

@jrconway3 jrconway3 self-assigned this Jan 3, 2025
@jrconway3 jrconway3 changed the title Add Combined Layer Assets Again (Pirate Hats) Add Combined Layer Assets Again (Pirate/Christmas Hats) Jan 3, 2025
@bluecarrot16
Copy link
Contributor

I think it was actually a good idea to separate the layers out and I oppose adding duplicate assets that can be trivially created using the generator.

By analogy, I would vote for the removal of "pigface bascinet," "round bascinet," "pigface bascinet raised," etc., that were added recently, since these assets can be created using the helmet + armor (e.g. bascinet helmet + pigface visor, bascinet helmet + round visor, etc.).

https://liberatedpixelcup.github.io/Universal-LPC-Spritesheet-Character-Generator/#?body=Body_color_light&head=Human_male_light&hat=Pigface_bascinet_steel

@jrconway3
Copy link
Contributor Author

Okay thanks for that update.

To clarify what I meant; I found it could be a bit annoying for the end-user to have to click through separate options to add these layers on, and then having to remove them again. It could be nice if, for example, we could tie these overlay layers to a specific asset. The pirate skulls on some of the hats as well as the trimming are designed for very specific assets, and if you add it then remove the base hat, its annoying to have to go back and remove these assets again separately.

Perhaps a better suggestion is: add the ability to have a prerequisite asset before being able to choose certain things, and remove those assets if the prerequisite is disabled. That would be pretty complicated to implement, but I think it would improve the usability.

And yeah, I thought about the visors but wasn't exactly sure about it. Originally I did all the helmets separately before doing the visors as well later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants