Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color picker replace preset colors with chosen colors once picked #603

Closed
brauliodiez opened this issue Dec 7, 2024 · 3 comments · Fixed by #644
Closed

Color picker replace preset colors with chosen colors once picked #603

brauliodiez opened this issue Dec 7, 2024 · 3 comments · Fixed by #644
Assignees
@jsanzdev

Comments

@brauliodiez
Copy link
Member

Right now the preset colors are shown by default

Captura de pantalla 2024-12-07 a las 11 24 37

It would be great if:

  • The preset transparent color is always visible and in the same position.
  • The rest of colors are being replaced as soon as the user picks color (first color picked, replace the index[1] of presets and so on.
  • We could use a circular approach, once we reach length index -1 start with position one.

We could add it to the Canvas context, even serialize it once we save the doc (this could be done in a separate stage).
@brauliodiez brauliodiez moved this to Backlog in QuickMock Dec 7, 2024
@brauliodiez brauliodiez moved this from Backlog to In Progress in QuickMock Dec 12, 2024
jsanzdev added a commit that referenced this issue Dec 14, 2024
@jsanzdev
Working on #603
cc9576a 
- Created a personalised palette and the ability to save the palettes.
@jsanzdev
Copy link
Collaborator

I created a first draft of this feature. Now we can save custom colors. Currently there is no limit on how many palettes we can save, however the color picker doesn't have a shared state so custom colors will not be shared between all the color pickers.

image

@brauliodiez
Copy link
Member Author

Good stuff !!!

Let's first add a limit, something like 20 colors, (then once you fill all the gaps, then you start in the zero index position, overwrite).

On the other hand let's, we should have a context with the list of shared colors.

jsanzdev added a commit that referenced this issue Jan 1, 2025
@jsanzdev
Merge branch 'dev' into feature/#603-Last-Used-Color-Picker
3367c8c
@jsanzdev
Copy link
Collaborator

jsanzdev commented Jan 1, 2025

  • Implemented Shared Context to share the custom colors on all color pickers.
  • Click to save, right click to override a saved color (includes tooltip with instructions).
image

Should we be saving the custom colours when users save their projects to a file?

@jsanzdev jsanzdev linked a pull request Jan 2, 2025 that will close this issue
Feature/#603 last used color picker #644
Merged
@jsanzdev jsanzdev mentioned this issue Jan 2, 2025
Merged
brauliodiez added a commit that referenced this issue Jan 4, 2025
@brauliodiez
Merge branch 'dev' into feature/#603-Last-Used-Color-Picker
47916be
brauliodiez added a commit that referenced this issue Jan 4, 2025
@brauliodiez
Merge branch 'dev' into feature/#603-Last-Used-Color-Picker
64087e0
brauliodiez added a commit that referenced this issue Jan 4, 2025
@brauliodiez
Merge pull request #644 from Lemoncode/feature/#603-Last-Used-Color-P…
66ffc89 
…icker

Feature/#603 last used color picker
@github-project-automation github-project-automation bot moved this from In Progress to Done in QuickMock Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsanzdev jsanzdev

Labels
None yet
Projects
QuickMock
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#603 last used color picker Lemoncode/quickmock
2 participants
@brauliodiez @jsanzdev