Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backendnodejs]-#5 console runner add creation of seed lookups roles #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[backendnodejs]-#5 console runner add creation of seed lookups roles #13

wants to merge 3 commits into from

Conversation

patrixampm
Copy link
Collaborator

@patrixampm patrixampm commented Dec 10, 2024 •
edited
Loading

Closed #5
I have created a DB model for lookups, and added some mock data with sample lookups with different roles. After, I have added an option to the console runner to add the mock data to our DB.

@patrixampm patrixampm self-assigned this Dec 10, 2024
@patrixampm patrixampm linked an issue Dec 10, 2024 that may be closed by this pull request
[Backend][nodejs-console-runner] Add creation of seed Lookups (roles) #5
Open
patrixampm
patrixampm commented Dec 10, 2024
View reviewed changes
Copy link
Collaborator Author

@patrixampm patrixampm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes reviewed. I formatted the document, and some double quotes " " have been changed for simple quotes ' '. Sorry for the excess changes.

manudous
manudous reviewed Dec 13, 2024
View reviewed changes
src/dals/lookup/index.ts Outdated Show resolved Hide resolved
@manudous
Copy link
Member

Remember use Closed , e.g. Closed #5, in the PR comment so that the issue is removed when the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudous manudous manudous left review comments

@brauliodiez brauliodiez Awaiting requested review from brauliodiez

Assignees

@patrixampm patrixampm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend][nodejs-console-runner] Add creation of seed Lookups (roles)
2 participants
@patrixampm @manudous