Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Quorum Slice Handler #4

Open
adrianmross opened this issue Sep 15, 2023 · 1 comment
Open

Inconsistent Quorum Slice Handler #4

adrianmross opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@adrianmross
Copy link
Collaborator

adrianmross commented Sep 15, 2023

https://github.com/adrianmross/standalone-scp/blob/464219e350e8be047590915242ce1099d86ace6e/parser.cpp#L139-L145

If a quorum slice is defined multiple times with different definitions, there is no inconsistency handler.

Instead it does a weird thing where it still prints out, just not the quorum slice.

@adrianmross adrianmross added the bug Something isn't working label Sep 15, 2023
@zek224 zek224 self-assigned this Sep 18, 2023
@zek224 zek224 moved this from Todo to In Progress in @F23 Consensus Research Sep 18, 2023
@zek224 zek224 moved this from In Progress to Done in @F23 Consensus Research Sep 27, 2023
@zek224
Copy link
Collaborator

zek224 commented Sep 27, 2023

Included in parser.cpp, checks if the node_name already exists in node_to_name and if so, skips node line and quorum slice line.

        if (nodeExists(node_name, node_to_name)) {
            cout << RED << "ERROR: Node name '" << node_name << "' already exists. Skipping this node and its quorum." << RESET << endl;
            getline(input_file, quorum_str);                // skip the quorum line
            getline(input_file, node_name);                 // read the blank line
            continue;                                       // skip the rest of the loop iteration
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants