Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Missing return value check #46

Open
novalis opened this issue May 11, 2022 · 0 comments
Open

Missing return value check #46

novalis opened this issue May 11, 2022 · 0 comments

Comments

@novalis
Copy link

novalis commented May 11, 2022

https://github.com/LedgerHQ/app-tezos/blob/6793ac50d3ee82d39dffce8d838b683916f768fb/src/apdu_hmac.c#L35

Here, the return value of generate_key_pair is not checked, but elsewhere (e.g. here), it is.

Presumably, annotating it with __attribute__((warn_unused_result)) would help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant