From ee826d3bacf8442d15638707600fc2691bbd9838 Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Sat, 18 Mar 2023 22:01:40 +0100 Subject: [PATCH 1/4] Fix: typos --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 789a604aa..a8774b1bf 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ - [Running all tests](#running-all-tests) - [With Makefile](#with-makefile) - [With yarn](#with-yarn) - - [Running a specific tests](#running-a-specific-tests) + - [Running a specific test](#running-a-specific-tests) - [Adding tests](#adding-tests) - [Zemu](#zemu) - [Update binaries](#update-binaries) @@ -99,7 +99,7 @@ Testing is done via the open-source framework [zemu](https://github.com/Zondax/z yarn test ``` -### Running a specific tests +### Running a specific test 1. Go to the `tests` folder and run: - ```sh @@ -128,7 +128,7 @@ Finally make sure you adapt the expected signature! #### Update binaries -Don't forget to update the binaries in the test folder. To do so, compile with those environement variables: +Don't forget to update the binaries in the test folder. To do so, compile with those environment variables: ```sh make DEBUG=1 ALLOW_DATA=1 @@ -145,7 +145,7 @@ Repeat the operation for a binary compiled with nanoX SDK and change for `ethere ## Contributing -Contributions are what make the open source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**. +Contributions are what makes the open source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**. If you have a suggestion that would make this better, please fork the repo and create a pull request. You can also simply open an issue with the tag `enhancement`. From 7bcbba437ba64a94ca189b6cd74ce46f4e89eddd Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Sat, 18 Mar 2023 22:02:52 +0100 Subject: [PATCH 2/4] Fix: typo --- doc/ethapp_plugins.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ethapp_plugins.adoc b/doc/ethapp_plugins.adoc index a3bdbbe27..f748eed3b 100644 --- a/doc/ethapp_plugins.adoc +++ b/doc/ethapp_plugins.adoc @@ -308,7 +308,7 @@ Provide a sample callback mechanism for common plugin actions (amount to string, Provide external plugins samples -Fully support Starkware as an independant application (APDU logic added) +Fully support Starkware as an independent application (APDU logic added) Support extra flags for the generic UI (fast confirmation on first screen, ...) From 2292008a37b32523fe1dd96074033d9f2aff111f Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Sat, 18 Mar 2023 22:04:09 +0100 Subject: [PATCH 3/4] Fix: typo --- doc/eth_starkware_extensions.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/eth_starkware_extensions.adoc b/doc/eth_starkware_extensions.adoc index 48e91fd8e..3ae66e21f 100644 --- a/doc/eth_starkware_extensions.adoc +++ b/doc/eth_starkware_extensions.adoc @@ -11,7 +11,7 @@ Application version 1.5.0 - 4th of October 2020 ## About -This specification describes the APDU messages interface implementing the Starkware extensions for the Ethereum appilcation +This specification describes the APDU messages interface implementing the Starkware extensions for the Ethereum application ## Modified general purpose APDUs From 44cc52263fec11f392d77ee6d4a2c22c67cc0e3f Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Sat, 18 Mar 2023 22:05:27 +0100 Subject: [PATCH 4/4] Fix: typo --- doc/eth_contract_support_embedded.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/eth_contract_support_embedded.adoc b/doc/eth_contract_support_embedded.adoc index 67c27c0c6..0bc4ce1de 100644 --- a/doc/eth_contract_support_embedded.adoc +++ b/doc/eth_contract_support_embedded.adoc @@ -12,7 +12,7 @@ This document described how a specific device UI for a smart contract can be add ## Standard support -The applications already includes dedicated UI support for those specific contract calls : +The applications already include dedicated UI support for those specific contract calls : * ERC 20 approve(address, uint256) - implementation in *src_features/erc20_approval* * ERC 20 transfer(address, uint256) - implementation in *src_features/signTx* @@ -46,7 +46,7 @@ The following online tool can be used to compute selectors https://emn178.github ## Sample implementation of a function call -This example describes how to implement a specific UI for a contract call. This exemple is using Starkex token deposit - *deposit(uint256 tokenId, uint256 vaultId, uint256 quantizedAmount)* +This example describes how to implement a specific UI for a contract call. This example is using Starkex token deposit - *deposit(uint256 tokenId, uint256 vaultId, uint256 quantizedAmount)* * Implement the specific UI logic in a new *src_features* subdirectory - note that strings.common.maxFee will be provisioned with the maximum fee to pay for this call