New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make colorama an optional dependency #52

Merged

yhql merged 1 commit into Ledger-Donjon:master from erdnaxe:drop_colorama

Oct 24, 2023

Contributor

erdnaxe commented Sep 27, 2023

This patch proposes to remove colorama as a dependency. User can still install colorama and follow the README instructions to get colors.

This reduces maintenance cost while maintaining cross-platform compatibility for colors.


          Make colorama an optional dependency

4f149f7

yhql approved these changes

View reviewed changes

yhql merged commit a1f1d0f into Ledger-Donjon:master

3 checks passed

erdnaxe deleted the drop_colorama branch

November 28, 2023 09:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet