Routine maintenance 2023-07 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chawes13
commented
Jul 31, 2023
| // Activate the timer | ||
| jest.runAllTimers() | ||
| return pendingPromise | ||
| }) | ||
|
|
||
| test('middleware rejects stubbed request after delay with error flag', () => { | ||
| jest.useFakeTimers() | ||
| jest.spyOn(global, 'setTimeout') |
There was a problem hiding this comment.
Resolves error received that expect(setTimeout) expects a spy
chawes13
commented
Jul 31, 2023
| "@babel/core": "^7.5.5", | ||
| "@launchpadlab/babel-preset": "^2.1.0", | ||
| "@launchpadlab/eslint-config": "^2.4.1", | ||
| "axios": "^0.18.0", |
There was a problem hiding this comment.
We're mocking this package entirely, so we don't actually need to install it locally for anything
chawes13
commented
Jul 31, 2023
| "@launchpadlab/babel-preset": "^2.1.1", | ||
| "@launchpadlab/eslint-config": "^3.0.1", | ||
| "codeclimate-test-reporter": "^0.5.1", | ||
| "documentation": "^14.0.2", |
There was a problem hiding this comment.
Only change that affects us is bullet points go from - to *
chawes13
commented
Jul 31, 2023
| }, | ||
| "dependencies": { | ||
| "es6-symbol": "^3.1.1", |
There was a problem hiding this comment.
This wasn't supported in IE, but that browser no longer needs support!
This was referenced Jul 31, 2023
bhennes2
approved these changes
Aug 4, 2023
| @@ -1,29 +1,27 @@ | |||
| import Symbol from 'es6-symbol' | |||
There was a problem hiding this comment.
In the changelog for this version change I'd imagine we'll note that IE6 support is now dropped?
There was a problem hiding this comment.
Good point! I'll add that to the GitHub release notes. We typically don't maintain changelog files on client-side libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepublishchanges in later versions of npm)