Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving the API response as per (SERVER+filename.png) #7

Open
3D-I opened this issue Oct 13, 2017 · 7 comments
Open

Serving the API response as per (SERVER+filename.png) #7

3D-I opened this issue Oct 13, 2017 · 7 comments

Comments

@3D-I
Copy link

3D-I commented Oct 13, 2017

I saw this line
acedac8#diff-828e0013b8f3bc1bb22b4f57172b019dR19

It seems very clear to me the file is already stored like that, it could be incredibly outstanding to have the option the filename to be served directly (an option, so to don't break the WP's compatibility).

In PHPBB as per the core code I can use the native function if so served instead of code a ugly one, with the facility to override the gravatars in a simply manner, all what I need is the SERVER+filename.png served as it is, I will take care of all the rest.

Please :)

@LasseRafn
Copy link
Owner

I don't understand the "problem", what are we trying to do? If it's related to using it with gravatar, all you have to do is use this syntax:

urlencode('https://ui-avatars.com/{urlEncodedName}/{size}/{background}/{fontColor}/{length}/{fontSize}/{isRounded}/{isUppercase}')

as the Gravatar fallback, like so:

https://www.gravatar.com/avatar/cd6dfa715835748e631bc00a4040d987?s=64&d=https%3A%2F%2Fui-avatars.com%2Fapi%2FLasse%2BRafn/128/19443a/fff

@3D-I
Copy link
Author

3D-I commented Oct 15, 2017

No, I do have a my own code for phpBB gravatars.

phpBB's avatars engine is way complex and works just around the filename.
If I have the filename served phpBB spreads the Initial Avatars board-wide, else I am limited just at view-topic and a few of locations, that's pitty you know.

@LasseRafn
Copy link
Owner

Okay, I think I understand 🤔 How would an example URL look?

Like: https://ui-avatars.com/AVATAR-FILENAME.png? 👍

@3D-I
Copy link
Author

3D-I commented Oct 16, 2017

g'morning, I am glad I got an enthusiastic like me. 👍
Let me think about this--
I got an idea on how to manage the issue by phpBB side, so to avoid to bother you :)

@3D-I
Copy link
Author

3D-I commented Oct 21, 2017

I succesfully managed the issue by my side, thanks for the outstandig support. 🥇

@jacobSingh
Copy link

Yes! I need the same feature. Would love to see this implemented (or maybe help?)

@cesarmtz93-wit
Copy link

Okay, I think I understand 🤔 How would an example URL look?

Like: https://ui-avatars.com/AVATAR-FILENAME.png? 👍

was this ever implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants