onColorChangedListener triggers way to often (and first values are not valid)

[buttairfly]

Hey Lars Werkman,
thank you for your great work with this colorPicker!
I use your colorPicker (with SV- and Opacitybars) to send an ip frame with the selected color to another device. I noticed, you trigger the onColorChangedListener on every ColorPicker.setNewCenterColor(.) call. This is wrong, if there are some bars (which update the actual color value with setNewCenterColor).

with this function update in ColorPicker it is solved:

/**
* Puts an ColorChanged Event on the listener.
*
*/
public void ColorChangedEvent(){
if (onColorChangedListener != null && mCenterNewColor != oldChangedListenerColor) {
onColorChangedListener.onColorChanged(mCenterNewColor);
oldChangedListenerColor = mCenterNewColor;
}
}

/**
* Change the color of the center which indicates the new color.
*
* @param color int of the color.
*/
public void setNewCenterColor(int color) {
mCenterNewColor = color;
mCenterNewPaint.setColor(color);
if (mCenterOldColor == 0) {
mCenterOldColor = color;
mCenterOldPaint.setColor(color);
}
invalidate();
}

and put
ColorPicker.ColorChangedEvent();
after every call of setNewCenterColor(.) in functions of the bars instead of .setColor(color).

in ColorPicker Functions, ColorChangedEvent() needs to be called after correct value is set to setNewCenterColor(.) function calls. (if a bar changes the value later on, a wrong value will be put on listener.

By the way... you dont see, how many listener Function calls you get, whith the old version by just using the colorpicker on an android device.

Best Regards!
Buttairfly

[kj800x]

This is a major issue that I'm also experiencing.

[kj800x]

I've looked into the suggestion buttairfly gave, but that just delegates the event triggering to the bars (0 bars = 0 events, 1 bar = 1 event, 2 bars = 2 events). A better way to approach the problem would be for the colorpicker to ask the bars for their values, and use that to calculate the new color, and then only the colorpicker should be allowed to trigger the event. I'm working on a pull request for this.

[jlarysz]

I can't get this color picker to work in Android IDE 1.5. I'm stuck on a duplicate class in the build:

Execution failed for task ':app:transformClassesWithJarMergingForDebug'.

com.android.build.api.transform.TransformException: java.util.zip.ZipException: duplicate entry: com/larswerkman/holocolorpicker/ColorPicker$OnColorChangedListener.class

and I can't find it. I've been looking all day - I think I have to try another color picker.

[holgi-s]

Using the 1.5 version I also noticd that when using a SVBar the onColorChanged is triggered twice, and the 1st event actually contains the wrong color.

In ColorPicker.onTouchEvent()
1st event on line 631:
setNewCenterColor(mCenterNewColor = calculateColor(mAngle));
with the color of the circle, not respecting saturation and value

2nd event on line 646:
mSVbar.setColor(mColor);
this time with the correct color