Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lls] Annotate mission scripts, correct issues identified #6225

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Sep 7, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Moves specs/types/Quest.lua to Container.lua to represent more generic definitions for mission/quest sections
  • Fixes some incorrectly parsed overloads in CBaseEntity
  • Annotates interaction mission scripts and interaction code
  • Fixes ordering for ZoneSection definitions so that all string types are not considered valid for entity functions
  • Corrects issues identified in mission scripts from annotations

Steps to test these changes

CI should pass, no impact to gameplay, and fixes petitions for Adoulin mission (addVar is undefined) along with an errant showText

@claywar claywar changed the title Lls/annotate missions [lls] Annotate mission scripts, correct issues identified Sep 7, 2024
Fix ordering for Container sections, correct overload

break out remaining overload definitions
@claywar claywar force-pushed the lls/annotate-missions branch from 19f5734 to 6ff1fcd Compare September 7, 2024 13:06
@claywar claywar merged commit 9f58bea into base Sep 7, 2024
12 checks passed
@claywar claywar deleted the lls/annotate-missions branch September 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants