Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Outgoing synth packet is always "your" synth result even though its from "others" #6545

Open
3 tasks done
WinterSolstice8 opened this issue Dec 18, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

n/a

Branch affected by issue

base

Steps to reproduce

enable filter of "other" synth results, see someone synth, get synth result anyway

Basically, we always send 0x06F when we should send 0x070 when it is received by "others". Our current implementation makes no distinction between "yours" and "others"

Expected behavior

enable filter of "other" synth results, see someone synth, dont get their synth

@WinterSolstice8 WinterSolstice8 added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant